fix swap functions correctness #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemire
reviewed
Aug 8, 2024
| bool SwapBytes32(char *data, size_t nbytes) { | ||
| if (nbytes % sizeof(uint32_t) != 0) return false; | ||
|
|
||
| #if defined(_MSC_VER) |
Member
There was a problem hiding this comment.
I am skeptical that this MS code is needed.
Member
Author
There was a problem hiding this comment.
Agreed. We can have SIMD support for this swap functions :-)
Member
There was a problem hiding this comment.
Agreed. We can have SIMD support for this swap functions :-)
Absolutely, although a single instruction can reverse 8 bytes so it is already very fast!!!
jasnell
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the implementation of Swap16, Swap32 and Swap64.